Step 2, CHIA-1922 20241116 second part of going on chain #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… coin spend downstream from potato_handler. We'll need to register the game related coins so we can route spends to channel handler to pass on to the game. We have an action cache in channel handler that remembers what move to pile into a good faith unroll, and we'll have to return that from ChannelHandler::set_state_for_coins in addition to the rest.
…n generator runtime error.
…ar up some confusion about whose turn it is and put in assertions in LiveGame in passthrough methods (and make referee_maker non public in there)
This reverts commit 8b13956.
…replicate our turn
…e most uses of ad-hoc state with them, since they encapsulate perfectly the necessary data to know what state the referee coin is in before this move and to create this move via a spend
… current state of the game. The test now fails downstream in the max iterations check because we're not tracking the game coins. That's next
…ough potato handler and channel handler so we can observe and react to spends of game coins at that layer and update our understanding. The spend on chain is causing an allowed slash, which needs to be investigated
prozacchiwawa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second part of full on chain transition, isolated here because it forks the test to set a canary for breaking the global on chain transition parts while preserving the full game finish test.