-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHIA-1862 Fix FullNodeAPI's request_block_headers returned filter #18923
CHIA-1862 Fix FullNodeAPI's request_block_headers returned filter #18923
Conversation
4c3c008
to
2c8e2fc
Compare
Pull Request Test Coverage Report for Build 12394466119Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
032dd93
to
9195013
Compare
your benchmark doesn't show that it's safe to remove the serialization optimization. |
9195013
to
41f24e2
Compare
looks good! It would be good to have proper test coverage of the new parsing function too |
41f24e2
to
6b2db3a
Compare
Done. Please note that while the test in question is skipped in main, enabling it and running it (with this extra coverage added to it) passes. |
6b2db3a
to
a357d84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think your test is being run. I think you need to delete this line:
https://github.com/Chia-Network/chia-blockchain/pull/18923/files#diff-3681c4e6fa79a6c076c109cb43bbd19b2bb909d4be47b6808289926148366fbdR253
a357d84
to
4a638bc
Compare
Purpose:
This fixes a bug where
request_block_headers
is not accounting for removals and additions when computing the transactions filter.Current Behavior:
request_block_headers
doesn't account for removals and additions in transactions filter computation.New Behavior:
request_block_headers
takes them properly into account.