Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add a couple of UI improvements #1084

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Conversation

Chesire
Copy link
Owner

@Chesire Chesire commented Oct 2, 2023

  • Fix the images not filling up the entire height of the cards
  • Add behaviour to perform search when pressing done on the keyboard

On some larger thinner handsets like ZFlip the images in the collection or search results do not
fill the whole card height, leaving a small gap. Update to make the image fill the max height.
When on the search screen, if the done button is pressed on the software keyboard it should perform
the search and close the keyboard.
@Chesire Chesire self-assigned this Oct 2, 2023
@commit-lint
Copy link

commit-lint bot commented Oct 2, 2023

Bug Fixes

  • images not filling full card (9efe2e8)

Features

  • pressing done should perform search (95eeb26)

Styles

Contributors

Chesire

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@Chesire Chesire merged commit 1983395 into master Oct 8, 2023
7 checks passed
@Chesire Chesire deleted the feature/ui-improvements branch October 8, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant