Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooker scheduling generators #104

Merged
merged 23 commits into from
Feb 23, 2021
Merged

Hooker scheduling generators #104

merged 23 commits into from
Feb 23, 2021

Conversation

mmghannam
Copy link
Collaborator

@mmghannam mmghannam commented Feb 18, 2021

Includes generators for all instances in problem sets described in here. Closes #98, #100, #101, #102.

@codecov-io
Copy link

codecov-io commented Feb 18, 2021

Codecov Report

Merging #104 (09eba2d) into main (23d2fb0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              main      #104    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           48        48            
  Lines         1022      1138   +116     
==========================================
+ Hits          1022      1138   +116     
Impacted Files Coverage Δ
geco/mips/scheduling/generic.py 100.00% <100.00%> (ø)
geco/mips/scheduling/heinz.py 100.00% <100.00%> (ø)
geco/mips/scheduling/hooker.py 100.00% <100.00%> (ø)
geco/mips/utilities/generic.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d2fb0...09eba2d. Read the comment docs.

@CharJon
Copy link
Owner

CharJon commented Feb 20, 2021

I wrote a prototype to see whether or not I prefer the heavily "lambdad" param generation over a less generalized one.
See c_params_generator_alternative and the two functions above.
I think we should use the more verbose one, as it is easier to see whats going on, even at the cost of more code. The verbose implementation can be checked at one glance.

@mmghannam
Copy link
Collaborator Author

I wrote a prototype to see whether or not I prefer the heavily "lambdad" param generation over a less generalized one.
See c_params_generator_alternative and the two functions above.
I think we should use the more verbose one, as it is easier to see whats going on, even at the cost of more code. The verbose implementation can be checked at one glance.

I migrated the old code to the new way.
Since this pull request contains a lot of changes already, what about we merge the parameter generation methods and add the missing MIP formulations in other pull-request?

@mmghannam mmghannam changed the title WIP: Hooker scheduling generators Hooker scheduling generators Feb 22, 2021
@CharJon CharJon merged commit eb965b7 into main Feb 23, 2021
@CharJon CharJon deleted the hooker-scheduling-generators branch February 23, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More scheduling generators (Hookers c-instances)
3 participants