Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new builtin actors v13.0.0-rc.1 #244

Merged
merged 37 commits into from
Feb 6, 2024
Merged

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Feb 2, 2024

Summary of changes
Changes introduced in this pull request:

  • New V13 builtin actors state code
  • fil_actors_shared
  • actors/account
  • actors/init
  • actors/cron
  • actors/paych
  • actors/system
  • actors/multisig
  • actors/market
  • actors/power
  • actors/reward
  • actors/verifreg
  • actors/miner
  • actors/datacap
  • actors/eam
  • actors/evm
  • actors/ethaccount
  • fil_actor_interface

Reference issue to close (if applicable)

Closes

Other information and links

@sudo-shashank sudo-shashank marked this pull request as ready for review February 2, 2024 15:09
@sudo-shashank sudo-shashank requested a review from a team as a code owner February 2, 2024 15:09
@sudo-shashank sudo-shashank requested review from elmattic and aatifsyed and removed request for a team February 2, 2024 15:09
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Contributor

@aatifsyed aatifsyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really review this - could you explain how you arrived at all of this code?
I understand it's some shallow copy of https://github.com/filecoin-project/builtin-actors?

How do you go from e.g a tagged release of the above repo to these 20k lines?

I think I would want to automate this medium term

@LesnyRumcajs
Copy link
Member

I can't really review this - could you explain how you arrived at all of this code? I understand it's some shallow copy of https://github.com/filecoin-project/builtin-actors?

How do you go from e.g a tagged release of the above repo to these 20k lines?

I think I would want to automate this medium term

I have never done it myself, but I assume it's copy-pasting the code from actors, gutting it a bit (no runtimes, no WASM) and adjusting the interface part so that the new version can be referenced from there.

I'd love to have this somehow automated, but I doubt it's a small task, and we need this code to do state migrations, i.e., we need it to support NV22.

@LesnyRumcajs
Copy link
Member

@aatifsyed could you please re-approve? I had to fix some conflicts.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit bd8d4cb Feb 6, 2024
5 checks passed
@LesnyRumcajs LesnyRumcajs deleted the builtin-actors-v13.0.0-rc.1 branch February 6, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants