-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new builtin actors v13.0.0-rc.1 #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really review this - could you explain how you arrived at all of this code?
I understand it's some shallow copy of https://github.com/filecoin-project/builtin-actors?
How do you go from e.g a tagged release of the above repo to these 20k lines?
I think I would want to automate this medium term
I have never done it myself, but I assume it's copy-pasting the code from actors, gutting it a bit (no runtimes, no WASM) and adjusting the interface part so that the new version can be referenced from there. I'd love to have this somehow automated, but I doubt it's a small task, and we need this code to do state migrations, i.e., we need it to support NV22. |
@aatifsyed could you please re-approve? I had to fix some conflicts. |
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links