Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release for V7.0.0-rc.1 #183

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Prepare release for V7.0.0-rc.1 #183

merged 5 commits into from
Oct 13, 2023

Conversation

sudo-shashank
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Update version

Reference issue to close (if applicable)

Closes

Other information and links

@sudo-shashank sudo-shashank marked this pull request as ready for review October 13, 2023 10:04
@sudo-shashank sudo-shashank requested a review from a team as a code owner October 13, 2023 10:04
@sudo-shashank sudo-shashank requested review from lemmih and aatifsyed and removed request for a team October 13, 2023 10:04
@sudo-shashank sudo-shashank added the Release PR which marks a new Release label Oct 13, 2023
@sudo-shashank sudo-shashank reopened this Oct 13, 2023
@LesnyRumcajs
Copy link
Member

Shouldn't the versions be 7.0.0-rc.1?

@sudo-shashank
Copy link
Contributor Author

Shouldn't the versions be 7.0.0-rc.1?

version follows major.minor.patch format only, the release tag will be marked as v7.0.0-rc.1

@LesnyRumcajs
Copy link
Member

Shouldn't the versions be 7.0.0-rc.1?

version follows major.minor.patch format only, the release tag will be marked as v7.0.0-rc.1

Why does it have to follow this format? For example, in ref-fvm one can add an extra suffix. See https://github.com/filecoin-project/ref-fvm/blob/e9044cb8eca4ca928bede06689c4408b7837cc6f/sdk/Cargo.toml#L4

Will the release on crates.io follow the git tag?

@sudo-shashank
Copy link
Contributor Author

Shouldn't the versions be 7.0.0-rc.1?

version follows major.minor.patch format only, the release tag will be marked as v7.0.0-rc.1

Why does it have to follow this format? For example, in ref-fvm one can add an extra suffix. See https://github.com/filecoin-project/ref-fvm/blob/e9044cb8eca4ca928bede06689c4408b7837cc6f/sdk/Cargo.toml#L4

Will the release on crates.io follow the git tag?

corrected

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@sudo-shashank sudo-shashank added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit f9c4b65 Oct 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@lemmih lemmih lemmih approved these changes

@aatifsyed aatifsyed Awaiting requested review from aatifsyed aatifsyed is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
Release PR which marks a new Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudo-shashank @LesnyRumcajs @codecov-commenter @lemmih