-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix date displayed with no Tx #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The fix works successfully, I can no longer recreate the issue on this branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tbaut looks good! I pushed the PR where I replaced the old AggregatedData with the new interface CallDataInfoFromChain. As I had errors during the build. Please confirm if it's correct
Thanks for the review. I'll merge this PR next week as it's touching quite some critical logic, and I'm not very available in the next days if something goes wrong. |
closes #430
This was more complex than expected. The problem was related to a race condition between
asMulti
calls)The second call can take time, and when changing accounts, a reset wouldn't be performed. Now since Promises can't be stopped, this resulted in the second promise resolving with outdated data. I solved it in making the 2 calls sequential and less dynamic. It's not really an issue since they should strictly follow each other. I've been consolidating all this logic which used to be separated, into the
usePendinTx
hook. It's a lot, but it should be more comprehensible already.To see the bug, you'd have to:
5EMm18Z8WWWT2wit1RxpoZv39goPdYmSksnDTePYAzrUhdJv
on Rococo.Submission checklist:
Compatibility