Feature/corpus form #1659
Open
Feature/corpus form #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also offer a reset sample
lukavdplas
requested changes
Nov 7, 2024
frontend/src/app/corpus-definitions/definitions-overview/definitions-overview.component.html
Show resolved
Hide resolved
frontend/src/app/corpus-definitions/form/field-form/field-form.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/corpus-definitions/form/field-form/field-form.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/corpus-definitions/form/meta-form/meta-form.component.html
Outdated
Show resolved
Hide resolved
Comment on lines
27
to
39
| <div class="field is-grouped"> | ||
| <div formGroupName="date_range"> | ||
| <label class="label" for="min">Start date</label> | ||
| <div class="control"> | ||
| <input class="input" type="date" name="min" formControlName="min" /> | ||
| </div> | ||
| <label class="label" for="max">End date</label> | ||
| <div class="control"> | ||
| <input class="input" type="date" name="max" formControlName="max" /> | ||
| </div> | ||
| <p class="help">Enter the earliest and latest date in your corpus in YYYY-MM-DD format</p> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Since we only use the year, you could make this a numeric control and just add January 1st for the min date, and December 31st for the max date.
In the help text, we could also mention that this doesn't need to be an exact year, it's just an indication for users.
frontend/src/app/corpus-definitions/form/meta-form/meta-form.component.html
Show resolved
Hide resolved
|
Something that occurred to me: the corpus fields in the form are based on the CSV columns, but they're not displaying which field maps to which column. This will get especially confusing if you rename the fields. |
This was
linked to
issues
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.