-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6704] [ENG-6705] Reference PR #10857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add management command to migrate preprint affiliations * make sure migrations uses primary instead of replica, improve tests * remove redundant permission --------- Co-authored-by: John Tordoff <>
* Add OOPSpam and Akismet metrics to spam report * Add spam/ham metrics for OOPSpam and Akismet with FK join fix, test cleanup * Add private spam metrics report with preprint inclusion * Validate category; add PrivateSpamMetricsReporter to monthly reports --------- Co-authored-by: Uditi Mehta <[email protected]>
prevent counted-usages with different `action_labels` from overwriting each other -- deduplicate only when `action_labels` match exactly
…d-update [ENG-6685] B&I Release Fixes
B&I Release - Migrate Preprint Affilations - Add OOPSpam and Akismet metrics to spam report - Add PrivateSpamMetricsReport - Update PrivateSpamMetricsReporter to work with refactored MonthlyReporter - Fix duplicate reports when run for past years - Fix counted-usage clobbers
Co-authored-by: abram axel booth <[email protected]>
cslzchen
commented
Dec 17, 2024
if category not in ['node', 'preprint']: | ||
raise ValueError(f"Invalid category '{category}'. Expected 'node' or 'preprint'.") | ||
|
||
log_model = NodeLog if category == 'node' else PreprintLog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: we may have not covered PreprintLog fixes/updates in DOI, need to take a look.
cslzchen
commented
Dec 17, 2024
|
||
|
||
@pytest.mark.django_db | ||
class TestAssignAffiliationsToPreprints: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: take a look at these tests, may be broken by DOI
cslzchen
merged commit Dec 18, 2024
2706450
into
feature/preprints-doi-versioning
13 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference PR for ENG-6704 and ENG-6705