Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6701] - Add tests for Preprint factory #10855

Conversation

Vlad0n20
Copy link

@Vlad0n20 Vlad0n20 commented Dec 16, 2024

Purpose

Add tests to check if PreprintFactory work properly

Changes

Create new file test_preprint_factory.py

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-6701

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a duplicate commit 548120d that has been merge in ef6a82e.

Not sure why GitHub didn't show the conflicts. Please clean up the commits and should be good to merge.

And don't forget to update the PR description.

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and will merge after Github actions have finished.

@cslzchen cslzchen merged commit e1a2630 into CenterForOpenScience:feature/preprints-doi-versioning Dec 18, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants