[ENG-6731] Fix zotero connection #10854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlius
commented
Dec 15, 2024
Comment on lines
+81
to
+82
| 'oauth_token': oauth_token, | ||
| 'oauth_verifier': oauth_verifier, |
There was a problem hiding this comment.
Need to forward these oauth1a specific query params to GV
adlius
commented
Dec 15, 2024
| gv_url = urlunparse(urlparse(GRAVYVALET_URL)._replace(path=f'/v1/{oauth_version}/callback', query=urlencode(query_params))) | ||
| requests.get(gv_url) | ||
| requests.get(gv_url, cookies=request.cookies) |
There was a problem hiding this comment.
Oauth1a process on GV side make use of sessions to store oauth1a_accound_id in between requests. Therefore we need to forward the cookies to GV upon callback.
brianjgeiger
requested changes
Dec 16, 2024
There was a problem hiding this comment.
Looks good other than test failures.
=================================== FAILURES ===================================
______________ TestBitbucketAuthViews.test_oauth_finish_enable_gv ______________
addons/base/tests/views.py:93: in test_oauth_finish_enable_gv
assert dict(parse_qsl(parsed_callback_url.query)) == query_params
E AssertionError
__________________ TestAuthViews.test_oauth_finish_enable_gv ___________________
addons/base/tests/views.py:93: in test_oauth_finish_enable_gv
assert dict(parse_qsl(parsed_callback_url.query)) == query_params
E AssertionError
__________________ TestAuthViews.test_oauth_finish_enable_gv ___________________
addons/base/tests/views.py:93: in test_oauth_finish_enable_gv
assert dict(parse_qsl(parsed_callback_url.query)) == query_params
E AssertionError
__________________ TestAuthViews.test_oauth_finish_enable_gv ___________________
addons/base/tests/views.py:93: in test_oauth_finish_enable_gv
assert dict(parse_qsl(parsed_callback_url.query)) == query_params
E AssertionError
_______________ TestGitHubAuthViews.test_oauth_finish_enable_gv ________________
addons/base/tests/views.py:93: in test_oauth_finish_enable_gv
assert dict(parse_qsl(parsed_callback_url.query)) == query_params
E AssertionError
__________________ TestAuthViews.test_oauth_finish_enable_gv ___________________
addons/base/tests/views.py:93: in test_oauth_finish_enable_gv
assert dict(parse_qsl(parsed_callback_url.query)) == query_params
E AssertionError
__________________ TestAuthViews.test_oauth_finish_enable_gv ___________________
addons/base/tests/views.py:93: in test_oauth_finish_enable_gv
assert dict(parse_qsl(parsed_callback_url.query)) == query_params
E AssertionError
__________________ TestAuthViews.test_oauth_finish_enable_gv ___________________
addons/base/tests/views.py:93: in test_oauth_finish_enable_gv
assert dict(parse_qsl(parsed_callback_url.query)) == query_params
E AssertionError
__________________ TestAuthViews.test_oauth_finish_enable_gv ___________________
addons/base/tests/views.py:93: in test_oauth_finish_enable_gv
assert dict(parse_qsl(parsed_callback_url.query)) == query_params
E AssertionError
=============================== warnings summary ===============================
adlius
merged commit b2f1a2b
into
CenterForOpenScience:feature/gravy_valet_integration
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket