[ENG-6732] Rework version creation for model and factory #10853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
commented
Dec 16, 2024
| instance.add_affiliated_institution(institution, auth.user, ignore_user_affiliation=True) | ||
|
|
||
| # Set other fields | ||
| # TODO: we should copy all fields |
There was a problem hiding this comment.
Note: will defer this to work in https://openscience.atlassian.net/browse/ENG-6701 where this factory will be tested and further updated.
cslzchen
force-pushed
the
feature/version-creation-rework
branch
from
3273e81 to
d7ad314
Compare
cslzchen
commented
Dec 16, 2024
cslzchen
merged commit 1bee842
into
CenterForOpenScience:feature/preprints-doi-versioning
2 of 6 checks passed
cslzchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rework version creation for model and factory
Changes
_create()worksQA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-6732