Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6700] Check and fix website tests #10850

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[ENG-6700] Check and fix website tests #10850

merged 2 commits into from
Dec 12, 2024

Conversation

Vlad0n20
Copy link

@Vlad0n20 Vlad0n20 commented Dec 12, 2024 •
edited by cslzchen
Loading

Purpose

Check and fix website tests

Changes

  • Update check for redirect in resolve_guid view
  • Combine overlapping code

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-6700

cslzchen
cslzchen approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎆 ! I will add an extra commit before merging this PR.

website/views.py Outdated Show resolved Hide resolved
website/views.py Outdated Show resolved Hide resolved
@cslzchen cslzchen changed the title [ENG-6700] Fix website tests [ENG-6700] Check and fix website tests Dec 12, 2024
@cslzchen cslzchen merged commit 9f2b980 into CenterForOpenScience:feature/preprints-doi-versioning Dec 12, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cslzchen cslzchen cslzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vlad0n20 @cslzchen