Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][ENG-6675] Assume default for global_ notifications #10845

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[Hotfix][ENG-6675] Assume default for global_ notifications #10845

merged 1 commit into from
Dec 11, 2024

Conversation

mfraezz
Copy link
Member

@mfraezz mfraezz commented Dec 11, 2024 •
edited
Loading

Purpose

Ensure deliverability of reviews notifications

Changes

  • If no preferences are configured, assume email_transactional for global_ notifications.
    • This behavior is congruent with expectations detailed in this comment

QA Notes

  • Review actions (accept/reject) should generate notification emails in the absence of configured NotificationSubscriptions

Side Effects

None expected

Ticket

https://openscience.atlassian.net/browse/ENG-6675

@mfraezz mfraezz requested a review from brianjgeiger December 11, 2024 21:25
brianjgeiger
brianjgeiger approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@brianjgeiger brianjgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@mfraezz mfraezz merged commit 9892ad5 into CenterForOpenScience:master Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjgeiger brianjgeiger brianjgeiger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfraezz @brianjgeiger