Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-6692] Versioned preprints refactor #10834

Merged
merged 8 commits into from
Dec 10, 2024
Merged

[ENG-6692] Versioned preprints refactor #10834

merged 8 commits into from
Dec 10, 2024

Conversation

Ostap-Zherebetskyi
Copy link

Purpose

Refactor versioned preprints

Changes

See diff

QA Notes

N/A

Documentation

N/A

Side Effects

N/A

Ticket

https://openscience.atlassian.net/browse/ENG-6692

@Ostap-Zherebetskyi Ostap-Zherebetskyi marked this pull request as ready for review December 9, 2024 15:41
@cslzchen cslzchen mentioned this pull request Dec 10, 2024
Merged
cslzchen
cslzchen requested changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall 👍 with a few suggestions.

I also make this PR block Bohdan's PR: #10833

And I think the conflicts come from my merge of Vlad's PR: #10813. I have two comments where you can refactored his code while fixing the conflicts. For this one, we can do it together tomorrow.

addons/base/views.py Outdated Show resolved Hide resolved
addons/osfstorage/decorators.py Outdated Show resolved Hide resolved
api/preprints/urls.py Show resolved Hide resolved
osf/models/base.py Outdated Show resolved Hide resolved
osf/models/base.py Outdated Show resolved Hide resolved
osf/models/base.py Show resolved Hide resolved
osf/models/base.py Outdated Show resolved Hide resolved
website/views.py Outdated Show resolved Hide resolved
website/views.py Outdated Show resolved Hide resolved
osf/models/base.py Show resolved Hide resolved
@cslzchen cslzchen mentioned this pull request Dec 10, 2024
Closed
cslzchen
cslzchen approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

@cslzchen cslzchen merged commit 6dc0b3c into CenterForOpenScience:feature/preprints-doi-versioning Dec 10, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cslzchen cslzchen cslzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ostap-Zherebetskyi @cslzchen