Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix density formula and momentum equation #260

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

imitrichev
Copy link
Contributor

@imitrichev imitrichev commented Nov 12, 2023

Fix density formula rho=(PM)/(RT)

and momentum equation (A/V is already taken into account in \dot m_s)

Also, please provide a description for \dot w_k, I don't understand what is it and if it is really needed in conservation eq. for fluid species k.
I feel like \dot w_k is molar rate of species k formation/consumption, and it is NOT needed in eqs. (4) and (5), due to eqs. are rewritten on MASS basis and this term is simply the same as the one with \dot s_k_j.

surface to volume ratio, A/V, is already taken into account in \dot m_s
Fix density formula in pfr.rst
Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these changes make sense to me.

$\dot \omega_k$ is the molar rate of production of species $k$ from gas phase reactions, which definitely does need to appear in the species and energy equations. $\dot s_k$ in contrast is the molar rate of production from surface reactions. These are the same definitions used in the other reactor formulations (though the definitions should probably be given again here).

@imitrichev
Copy link
Contributor Author

Dear Ray,
thank you for approving this.

Also, thank for explaining about \dot w - it is about gas-phase reactions. Of course, if PFR can account for gas-phase chemistry, these terms should be present in the equations.

@speth speth merged commit 94e2ea8 into Cantera:main Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants