Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests framework #2

Draft
wants to merge 44 commits into
base: main
Choose a base branch
from
Draft

Tests framework #2

wants to merge 44 commits into from

Conversation

ma595
Copy link
Member

@ma595 ma595 commented Jan 27, 2023

No description provided.

- do not compute NEE if FC entirely NULL
- do not put NEE on file if FC missing or entirely NULL
- do not create U* file if U*, NEE or FC are missing or entirely invalid
- do not create ENERGY file if H or LE missing or entirely invalid
- fixed bug on quality flags for gapfilled LE and H. Correctly calculate the QC value in case of missing data
- renamed vars from SW_IN_M, SW_IN_mqc to SW_IN_m, SW_IN_mqc
- fixed: changing the value of the QC to -9999 when it was not possible to calculate the energy balance and create the LE_Corr. It is also a "known issue" in FLUXNET2015 release
- cosmetic fixes
- added disabled refactored code (disabled to maintain consistency)
+ added vc++ 2008 solution (was missing!)
+ created Makefile for gf_mds
- removed common_pi.c (not used)

common:
# changed internal defines \ enums \struct for new gf_mds code
# some funcs now using timeres enum instead of hourly bool var
# gf_mds is now an unique func and it has new parameters (QC thresholds, symmetrical mean, max MDV window, ...)
- removed gf_mds_with_qc, gf_mds_with_bounds, temp_gf_mds (see above)
+ added some new funcs: get_rows_count_by_timeres, check_timestamp, timestamp_difference_in_seconds
# mystrcat renamed in string_concat

qc_auto:
# upgraded to v1.01
# minor fixes to reflect changes in common func

ustar_mp:
# upgraded to v1.01
# minor fixes to reflect changes in common func

meteo_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

nee_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

energy_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

gf_mds:
# upgraded to v3.0
# big fixes to reflect changes in common func
# now using "driver" instead of fluxes name
+ each driver now has a min and max tolerance customizable value
+ added driver QC threshold change
+ added symmentrical mean computation
+ added max MDV window parameter

SW_IN_POT_Calculator:
# upgraded to v1.01
# minor fixes to reflect changes in common func

shift_solar_noon:
# upgraded to v1.01
# minor fixes to reflect changes in common func

ure:
# upgraded to v1.01
# minor fixes to reflect changes in common funcs
# fixed gf computation
# changed comments

qc_auto:
# replaced 'founded' with 'found'

meteo_proc:
# replaced 'founded' with 'found'

nee_proc:
# fixed meteo import
# fixed outputs computation
# memory will be freed per site to prevent out of memory
# replaced 'founded' with 'found'

energy_proc:
# fixed meteo import
# fixed outputs computation
# replaced 'founded' with 'found'

ure:
# replaced 'founded' with 'found'

ustar_mp:
# replaced 'founded' with 'found'
… tools:

qc_auto
ustar_mp
meteo_proc
nee_proc
energy_proc
gf_mds
SW_IN_POT_Calculator
shift_solar_noon
ure
@ma595 ma595 marked this pull request as draft January 30, 2023 11:07
ARibecaJob and others added 22 commits April 7, 2023 16:14
+ added vc++ 2008 solution (was missing!)
+ created Makefile for gf_mds
- removed common_pi.c (not used)

common:
# changed internal defines \ enums \struct for new gf_mds code
# some funcs now using timeres enum instead of hourly bool var
# gf_mds is now an unique func and it has new parameters (QC thresholds, symmetrical mean, max MDV window, ...)
- removed gf_mds_with_qc, gf_mds_with_bounds, temp_gf_mds (see above)
+ added some new funcs: get_rows_count_by_timeres, check_timestamp, timestamp_difference_in_seconds
# mystrcat renamed in string_concat

qc_auto:
# upgraded to v1.01
# minor fixes to reflect changes in common func

ustar_mp:
# upgraded to v1.01
# minor fixes to reflect changes in common func

meteo_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

nee_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

energy_proc:
# upgraded to v1.01
# minor fixes to reflect changes in common func

gf_mds:
# upgraded to v3.0
# big fixes to reflect changes in common func
# now using "driver" instead of fluxes name
+ each driver now has a min and max tolerance customizable value
+ added driver QC threshold change
+ added symmentrical mean computation
+ added max MDV window parameter

SW_IN_POT_Calculator:
# upgraded to v1.01
# minor fixes to reflect changes in common func

shift_solar_noon:
# upgraded to v1.01
# minor fixes to reflect changes in common func

ure:
# upgraded to v1.01
# minor fixes to reflect changes in common funcs
# fixed gf computation
# changed comments

qc_auto:
# replaced 'founded' with 'found'

meteo_proc:
# replaced 'founded' with 'found'

nee_proc:
# fixed meteo import
# fixed outputs computation
# memory will be freed per site to prevent out of memory
# replaced 'founded' with 'found'

energy_proc:
# fixed meteo import
# fixed outputs computation
# replaced 'founded' with 'found'

ure:
# replaced 'founded' with 'found'

ustar_mp:
# replaced 'founded' with 'found'
… tools:

qc_auto
ustar_mp
meteo_proc
nee_proc
energy_proc
gf_mds
SW_IN_POT_Calculator
shift_solar_noon
ure
# fixed bug that occurs when TS and SWC columns have non-sequential or missing profiles
…y-with-new-enforcement-of-single-declaration-of-universal-variables

Fixing compilation issues with newer versions of GCC
Added new mode for locating string with faster mode of execution for nee_proc
Adjust MDS to support additional parameters
Previous commit had not fixed conflict resolution, only preserved automated Github annotations
gilbertozp and others added 8 commits September 10, 2024 18:01
Apply patch from Alessio to ure/dataset.c for timestamp handling. This patch was pending from previous merges from PR#52 and PR#59. All tests results comparable to PR#59 as expected.
Remove reference to issue

Co-authored-by: Dominic Orchard <[email protected]>
Remove reference to issue

Co-authored-by: Dominic Orchard <[email protected]>
--era-fy and --era-ly not needed here
Added missing parameters required (and docs) to run program on the sample data
@ma595 ma595 force-pushed the tests_framework branch 3 times, most recently from 4b2d6ae to a98c3e4 Compare October 18, 2024 10:40
The -a flag causes the build to break on HPC systems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants