Added de_DE support, deactivated original led mapping #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
the RoccatVulcanAimo module has wrong LED mappings on my german keyboard. I think of two reasons for this:
a) vulcan aimo 121 has a different mapping
b) de_DE layout is different to the original one in the code
I can't test anything else than de_DE on my vulcan 121 due to missing hardware (sorry, just one keyboard in my set :) )
But all signs point to possibility b), because the german keymap has also a slightly different Key style in the hardware layout. Producing a series of keyboards with different country codes would make sense.
I've commented the original mapping and added my de_DE mapping for Vulcan Aimo 121. So beware when you accept this pull without reediting.
br and a happy new 2022,
Michael