Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the TS option to only be visible in dev environments #2660

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

douira
Copy link
Collaborator

@douira douira commented Aug 12, 2024

  • Hide the TS option to only be visible in dev environments
  • Rename the option in config files to reset it after having hidden it. (to prevent people who've turned it off from being unable to turn it on again)

Rename the option in config files to reset it after having hidden it. (to prevent people who've turned it off from being unable to turn it on again)
@jellysquid3 jellysquid3 merged commit 50e6376 into CaffeineMC:dev Aug 12, 2024
1 check passed
@NebelNidas
Copy link
Contributor

Why shouldn't users with weak machines be able to turn this off if they don't necessarily care about translucent objects looking correct? Is the impact of translucency sorting really that low?

@jellysquid3
Copy link
Member

On the GPU, there is no additional overhead (the same stuff just gets rendered in a different order.)

On the CPU, there is some overhead... But the way Douira's approach works allows for translucent objects to only be re-sorted when strictly necessary, meaning that very little (or possibly none) of the geometry needs to be sorted when you move around. And, even then, you may have to move around a lot before you reach that threshold.

Point being, we're talking about less than a percent of the frame time in any reasonable situation, and only periodically at that. We've not had reports from players suggesting it causes a performance regression, or that it is worth disabling in any situation.

@jellysquid3
Copy link
Member

jellysquid3 commented Aug 20, 2024

Screencast_20240214_001830_trimmed.webm

Even with a completely unreasonable and contrived example (an entire world made of honey blocks, over 10 GB of geometry) there is minimal performance impact from sorting the geometry, and each frame still manages to look perfectly correct.

@NebelNidas
Copy link
Contributor

NebelNidas commented Aug 20, 2024

Oh wow, that's truly impressive indeed. I was asking since I have some family members with very slow laptops, where every option to turn off unnecessary eye-candy helps. But if we're talking about less than 1% frame times, it should be fine I guess. Thanks for the detailed anwser!

@douira douira deleted the hide-ts-option branch September 14, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants