Shadow com.lodborg.intervaltree into sodium #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes look fine, but we might want to modernize the code for Java 8+ and remove the dead code we aren't using later. |
jellysquid3
approved these changes
Aug 7, 2024
|
I already had IJ highlight and remove dead code. As for Java 8, it might require a more substantial refactor to change it to properly use generics throughout. |
|
This needs to be rebased on /dev, since we just merged the multi-loader branch. |
…cleanup) modifications. This avoids a dependency and makes modloading easier, espcially since this dependency is unlikely to get updated again or require changes.
douira
force-pushed
the
shadow-interval-tree-dep
branch
from
c7452a8 to
4d01b81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shadows the interval tree library into sodium with insubstantial (just cleanup) modifications.
This avoids a dependency and makes modloading easier, espcially since this dependency is unlikely to get updated again or require changes.
I've copied the MIT license declaration of the original work into each file as a header with a note and a link to the library's own repo.