Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pointer types when calling into Kernel32.SetEnvironmentVariableW #2143

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

jellysquid3
Copy link
Member

@jellysquid3 jellysquid3 commented Oct 26, 2023

This fixes the target signature to be pointer-pointer-int instead of long-long-int, which fixes a crash in 32-bit environments.

Fixes #2142.

@jellysquid3 jellysquid3 added the S-needs-testing Status: Needs testing label Oct 26, 2023
@jellysquid3 jellysquid3 changed the title Use pointer types when calling into Kernel32.SetEnvironmentVariableW (#2142) Use pointer types when calling into Kernel32.SetEnvironmentVariableW Oct 26, 2023
@jellysquid3 jellysquid3 merged commit 6cec89b into dev Oct 31, 2023
2 checks passed
@jellysquid3 jellysquid3 deleted the issue2142 branch December 5, 2023 22:58
IMS212 pushed a commit to IMS212/sodium-fabric that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-testing Status: Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sodium 0.5.3 - Execution protection violation
1 participant