[CBRD-25757] check coercibility of SP parameter default values without actually coercing it #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly coerce it to the parameter type . do not wrap SP parameter default values with CAST op; send them as string values as saved in the catalog
hyunikn
requested review from
hgryoo and
beyondykk9
and removed request for
beyondykk9
hyunikn
commented
Dec 24, 2024
| @@ -19440,7 +19440,7 @@ pt_coerce_value_for_default_value (PARSER_CONTEXT * parser, PT_NODE * src, PT_NO | |||
| implicit_coercion = true; | |||
| } | |||
|
|
|||
| return pt_coerce_value_internal (parser, src, dest, desired_type, data_type, true, implicit_coercion); | |||
There was a problem hiding this comment.
true 는 '... c char := 'abc' ...' 와 같은 경우 에러를 일으킵니다.
hyunikn
commented
Dec 24, 2024
| error = | ||
| pt_coerce_value_for_default_value (parser, default_value, default_value, param->type_enum, | ||
| pt_coerce_value_for_default_value (parser, default_value, dummy, param->type_enum, |
There was a problem hiding this comment.
형변환 가능성 검사만 하고 실제 적용하지는 않습니다.
hyunikn
commented
Dec 24, 2024
| @@ -2425,8 +2425,6 @@ jsp_get_default_expr_node_list (PARSER_CONTEXT *parser, cubpl::pl_signature &sig | |||
| else | |||
| { | |||
| default_next_node = pt_make_string_value (parser, sig.arg.arg_default_value[i]); | |||
| default_next_node = pt_wrap_with_cast_op (parser, default_next_node, pt_db_to_type_enum ((DB_TYPE) sig.arg.arg_type[i]), | |||
There was a problem hiding this comment.
cast op 로 감싸지 않고 문자열 그대로 pl 서버로 보냅니다.
hyunikn
changed the title
|
이슈와의 링크가 잘못되어 닫습니다. 다시 만들겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25757
인자 타입에서의 NUMERIC, CHAR 는 실제로 NUMERIC(ANY, ANY), CHAR(ANY) 를 의미하나,
NUMERIC(ANY, ANY), CHAR(ANY) 로의 형변환이 큐브리드에 아직 구현되지 않았기 때문에
일단, 현단계에서 CBRD-25690은 아래와 같이 해결한다.