[CBRD-25719] Fix an issue where [user_schema] was incorrectly stored or missing in the condition and action_definition columns of the db_trigger catalog during trigger creation or loaddb execution with legacy unload files

src/object/trigger_manager.c

@@ -1668,7 +1668,8 @@ compile_trigger_activity (TR_TRIGGER * trigger, TR_ACTIVITY * activity, int with
       class_mop = ((curname == NULL && tempname == NULL) ? NULL : trigger->class_mop);
 
       activity->statement =
-	pt_compile_trigger_stmt ((PARSER_CONTEXT *) activity->parser, text, class_mop, curname, tempname);
+	pt_compile_trigger_stmt ((PARSER_CONTEXT *) activity->parser, text, class_mop, curname, tempname,
+				 &activity->source);
       if (activity->statement == NULL || pt_has_error ((PARSER_CONTEXT *) activity->parser))
 	{
 	  error = er_errid ();

src/parser/compile.c

@@ -83,6 +83,7 @@ static PT_NODE *pt_find_lck_class_from_partition (PARSER_CONTEXT * parser, PT_NO
 static int pt_in_lck_array (PT_CLASS_LOCKS * lcks, const char *str, LC_PREFETCH_FLAGS flags);
 
 static void remove_appended_trigger_info (char *msg, int with_evaluate);
+static char *change_trigger_action_query (PARSER_CONTEXT * parser, PT_NODE * statement, int with_evaluate);
 
 static PT_NODE *pt_set_trigger_obj_pre (PARSER_CONTEXT * parser, PT_NODE * node, void *arg, int *continue_walk);
 static PT_NODE *pt_set_trigger_obj_post (PARSER_CONTEXT * parser, PT_NODE * node, void *arg, int *continue_walk);
@@ -1043,6 +1044,74 @@ remove_appended_trigger_info (char *msg, int with_evaluate)
     }
 }
 
+/*
+ * change_trigger_action_query () - remove appended trigger info
+ *   parser(in):
+ *   action_stmt(in):
+ *   with_evaluate(in):
+ */
+static char *
+change_trigger_action_query (PARSER_CONTEXT * parser, PT_NODE * statement, int with_evaluate)
+{
+  int result_len = 0;
+  char *result = NULL;
+  char *new_trigger_stmt_str = NULL;
+  unsigned int save_custom;
+
+  assert (parser != NULL || statement != NULL);
+
+  save_custom = parser->custom_print;
+
+  parser->flag.is_parsing_trigger = 1;
+
+  result = parser_print_tree_with_quotes (parser, statement);
+
+  parser->flag.is_parsing_trigger = 0;
+  parser->custom_print = save_custom;
+
+  if (result == NULL)
+    {
+      return NULL;
+    }
+
+  /* remove appended trigger evaluate info */
+  if (with_evaluate)
+    {
+      char *p = NULL;
+      const char *remove_eval_prefix = "evaluate (";
+      size_t remove_eval_suffix_len;
+
+      p = strstr (result, remove_eval_prefix);
+      if (p != NULL)
+	{
+	  p = (char *) memmove (p, p + strlen (remove_eval_prefix), strlen (p) - strlen (remove_eval_prefix) + 1);
+	}
+
+      remove_eval_suffix_len = strlen (p);
+      if (remove_eval_suffix_len > 0 && p[remove_eval_suffix_len - 1] == ')')
+	{
+	  p[remove_eval_suffix_len - 1] = '\0';
+	}
+    }
+
+  result_len = strlen (result) + 1;
+  if (result_len < 0)
+    {
+      return NULL;
+    }
+
+  new_trigger_stmt_str = (char *) malloc (result_len);
+  if (new_trigger_stmt_str == NULL)
+    {
+      er_set (ER_ERROR_SEVERITY, ARG_FILE_LINE, ER_OUT_OF_VIRTUAL_MEMORY, 1, (size_t) result_len);
+      return NULL;
+    }
+
+  snprintf (new_trigger_stmt_str, result_len, "%s", result);
+
+  return new_trigger_stmt_str;
+}
+
 /*
  * pt_compile_trigger_stmt () - Compiles the trigger_stmt so that it can be
  * 	executed by pt_exec_trigger_stmt
@@ -1057,7 +1126,7 @@ remove_appended_trigger_info (char *msg, int with_evaluate)
 
 PT_NODE *
 pt_compile_trigger_stmt (PARSER_CONTEXT * parser, const char *trigger_stmt, DB_OBJECT * class_op, const char *name1,
-			 const char *name2)
+			 const char *name2, char **new_trigger_stmt)
 {
   char *stmt_str = NULL;
   const char *class_name;
@@ -1066,7 +1135,7 @@ pt_compile_trigger_stmt (PARSER_CONTEXT * parser, const char *trigger_stmt, DB_O
   PT_NODE *err_node;
   int with_evaluate;
 
-  assert (parser != NULL);
+  assert (parser != NULL || !*new_trigger_stmt);
 
   if (!trigger_stmt)
     return NULL;
@@ -1160,8 +1229,13 @@ pt_compile_trigger_stmt (PARSER_CONTEXT * parser, const char *trigger_stmt, DB_O
       upd->info.update.spec = entity;
     }
 
+  /* prevents forced cast() within the code. (parser->flag.is_parsing_trigger == 1 && p->info.expr.flag != 0) */
+  parser->flag.is_parsing_trigger = 1;
+
   statement = pt_compile (parser, statement);
 
+  parser->flag.is_parsing_trigger = 0;
+
   /* Remove those info we append, which users can't understand them */
   if (pt_has_error (parser))
     {
@@ -1177,6 +1251,21 @@ pt_compile_trigger_stmt (PARSER_CONTEXT * parser, const char *trigger_stmt, DB_O
   /* We need to do view translation here on the expression to be executed. */
   if (statement)
     {
+      char *new_trigger_stmt_str = NULL;
+
+      with_evaluate = strstr (trigger_stmt, "EVALUATE ( ") != NULL ? true : false;
+
+      new_trigger_stmt_str =
+	change_trigger_action_query (parser, statement->info.scope.stmt->info.trigger_action.expression, with_evaluate);
+      if (new_trigger_stmt_str == NULL)
+	{
+	  return NULL;
+	}
+
+      free_and_init (*new_trigger_stmt);
+      *new_trigger_stmt = strdup (new_trigger_stmt_str);
+      free_and_init (new_trigger_stmt_str);
+
       statement->info.scope.stmt->info.trigger_action.expression =
 	mq_translate (parser, statement->info.scope.stmt->info.trigger_action.expression);
       /*

src/parser/parse_tree.c

@@ -1233,6 +1233,7 @@ parser_create_parser (void)
   parser->flag.is_auto_commit = 0;
   parser->flag.is_parsing_static_sql = 0;
   parser->flag.is_parsing_unload_schema = 0;
+  parser->flag.is_parsing_trigger = 0;
 
   parser->external_into_label = NULL;
   parser->external_into_label_cnt = 0;

src/parser/parse_tree.h

@@ -4020,6 +4020,7 @@ struct parser_context
     unsigned is_auto_commit:1;	/* set to true, if auto commit. */
     unsigned is_parsing_static_sql:1;	/* For PL/CSQL's static SQL: parameterize PL/CSQL variable symbols (to host variable) */
     unsigned is_parsing_unload_schema:1;	/* Parsing in unload: used to parse the scode (original query) of PL/CSQL to remove the owner. */
+    unsigned is_parsing_trigger:1;
   } flag;
 };
 

src/parser/parse_tree_cl.c

@@ -11663,6 +11663,12 @@ pt_print_expr (PARSER_CONTEXT * parser, PT_NODE * p)
 	}
       else
 	{
+	  if (parser->flag.is_parsing_trigger == 1 && p->info.expr.flag != 0)
+	    {
+	      q = pt_append_varchar (parser, q, r1);
+	      break;
+	    }
+
 	  r2 = pt_print_bytes (parser, p->info.expr.cast_type);
 	  q = pt_append_nulstring (parser, q, " cast(");
 	  q = pt_append_varchar (parser, q, r1);
@@ -13020,7 +13026,7 @@ pt_print_insert (PARSER_CONTEXT * parser, PT_NODE * p)
 
   // TODO: [PL/CSQL] need refactoring
   unsigned int save_custom = parser->custom_print;
-  if (parser->flag.is_parsing_static_sql == 1)
+  if (parser->flag.is_parsing_static_sql == 1 || parser->flag.is_parsing_trigger == 1)
     {
       parser->custom_print |= PT_SUPPRESS_RESOLVED;
       parser->custom_print & ~PT_PRINT_ALIAS;
@@ -13576,8 +13582,6 @@ pt_print_name (PARSER_CONTEXT * parser, PT_NODE * p)
   PARSER_VARCHAR *q = NULL, *r1;
   unsigned int save_custom = parser->custom_print;
 
-  char *dot = NULL;
-
   parser->custom_print = parser->custom_print | p->info.name.custom_print;
 
   if (!(parser->custom_print & PT_SUPPRESS_META_ATTR_CLASS) && (p->info.name.meta_class == PT_META_CLASS))

src/parser/parser.h

@@ -203,7 +203,7 @@ extern "C"
   extern PT_NODE *pt_class_pre_fetch (PARSER_CONTEXT * parser, PT_NODE * statement);
 
   extern PT_NODE *pt_compile_trigger_stmt (PARSER_CONTEXT * parser, const char *trigger_stmt, DB_OBJECT * class_op,
-					   const char *name1, const char *name2);
+					   const char *name1, const char *name2, char **new_trigger_stmt);
   extern int pt_exec_trigger_stmt (PARSER_CONTEXT * parser, PT_NODE * trigger_stmt, DB_OBJECT * object1,
 				   DB_OBJECT * object2, DB_VALUE * result);