-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUBVEC-14] CREATE TABLE: 2. Show 'VECTOR' column type when 'desc' #5724
Merged
+42
−1
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cc295a7
feat(csql_grammar.y): can create vector table with arguments
vimkim 40c16e4
feat(object, query, etc.): add DB_TYPE_VECTOR, tp_Vector - desc table…
vimkim 5f91731
fix(object_primitive): remove unnecessary array bound check
vimkim 06ca368
fix(csql_grammar): wrong merge resolution
vimkim 5e81265
minor: remove trailing comma
vimkim 71ec4c0
feat(object_printer): handle DB_TYPE_VECTOR in describe_domain
vimkim 88fa060
refactor(object_primitive): move tp_Vector to below tp_Sequence
vimkim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25042,6 +25042,9 @@ qexec_schema_get_type_name_from_id (DB_TYPE id) | |
case DB_TYPE_SEQUENCE: | ||
return "SEQUENCE"; | ||
|
||
case DB_TYPE_VECTOR: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NIT: JSON 다음에 추가 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 위와 동일 |
||
return "VECTOR"; | ||
|
||
case DB_TYPE_NCHAR: | ||
return "NCHAR"; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT:
JSON 다음에 추가
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB_TYPE_SEQUENCE 다음에 추가하는 방식으로 통일하는 것을 제안드립니다.
많은 switch-case문에서 DB_TYPE_SEQUENCE를 특수 처리하는 패턴을 그대로 따르기 때문에, 리뷰 과정에서 코드의 의도를 파악하기가 더 용이할 것으로 생각됩니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L
NIT 의견이기 때문에 @vimkim님이 선택하시면 되겠습니다. 일부는 JSON 뒤에 일부는 MULTISET 뒤에 정렬되어 있어서 일관성 있게 정리되었으면 하는 바람으로 드린 의견입니다. 추후 VECTOR 타입 구현이 달라질 수도 있구요.