Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25722] Enable correlated subquery caching with type_sp included in the subquery. #5707

Merged
merged 2 commits into from
Dec 13, 2024
Merged

[CBRD-25722] Enable correlated subquery caching with type_sp included in the subquery. #5707

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcae9eb
type_sp caching
xmilex-git Dec 12, 2024
4c7ba35
apply review
xmilex-git Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/parser/xasl_generation.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27622,6 +27622,27 @@ pt_make_sq_cache_key_struct (QPROC_DB_VALUE_LIST key_struct, void *p, int type)
}
}
break;
case TYPE_SP:
regu_var_list_p = regu_src->value.sp_ptr->args;
while (regu_var_list_p)
{
if (!regu_var_list_p)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while 루프로 인해, 이 조건은 항상 false일 거 같습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 적용했습니다. 확인해주세요

{
return ER_FAILED;
}
regu_src = &regu_var_list_p->value;
ret = pt_make_sq_cache_key_struct (key_struct, (void *) regu_src, SQ_TYPE_REGU_VAR);
if (ret == ER_FAILED)
{
return ER_FAILED;
}
else
{
cnt += ret;
}
regu_var_list_p = regu_var_list_p->next;
}
break;
case TYPE_POSITION:
case TYPE_LIST_ID:
/* Currently not supported, implement later */
Expand All @@ -27644,8 +27665,6 @@ pt_make_sq_cache_key_struct (QPROC_DB_VALUE_LIST key_struct, void *p, int type)
case TYPE_CLASSOID:
case TYPE_REGUVAL_LIST:
case TYPE_REGU_VAR_LIST:

case TYPE_SP:
/* Result Cache not supported */
return ER_FAILED;
break;
Expand Down
Loading