[CBRD-25028] Disable heap_chnguess_realloc() function, which is inaccessible from heap_Guesschn #5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H2SU
reviewed
Dec 9, 2024
YeunjunLee
reviewed
Dec 9, 2024
src/storage/heap_file.c
Outdated
| static int heap_chnguess_realloc (void); | ||
| #endif /* #if defined (ENABLE_UNUSED_FUNCTION) */ |
There was a problem hiding this comment.
Nit. #if defined 구문이 바로 위에 있기 때문에 주석을 통한 정보 제공이 불필요하다고 생각합니다.
Suggested change
| #endif /* #if defined (ENABLE_UNUSED_FUNCTION) */ | |
| #endif |
hornetmj
reviewed
Dec 11, 2024
src/storage/heap_file.c
Outdated
| @@ -670,7 +670,7 @@ static int heap_scancache_end_internal (THREAD_ENTRY * thread_p, HEAP_SCANCACHE | |||
| #if defined (ENABLE_UNUSED_FUNCTION) | |||
| static SCAN_CODE heap_get_if_diff_chn (THREAD_ENTRY * thread_p, PAGE_PTR pgptr, INT16 slotid, RECDES * recdes, | |||
| bool ispeeking, int chn, MVCC_SNAPSHOT * mvcc_snapshot); | |||
| #endif /* ENABLE_UNUSED_FUNCTION */ | |||
There was a problem hiding this comment.
어떤 #if 매크로와 쌍인지 쉽게 인지하기 위해서 #endif /* */ 형식을 권장합니다. 따라서, 제거하지 말아주세요. 또한 추가하신 %if ~ #endif의 #endif에도 적용해 주세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25028
Purpose
Implementation
Remarks