Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-24764] Fix start_vpid to not return NULL when the max_bestspace_entries parameter is greater than zero #5656

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

InChiJun
Copy link

@InChiJun InChiJun commented Dec 1, 2024

http://jira.cubrid.org/browse/CBRD-24764

Purpose

  • start_vpid 값은 heap_stats_sync_bestspace() 함수에서 디버그 로깅 목적으로 사용됨
  • max_bestspace_entries 파라미터의 값이 0보다 클 때 start_vpid 값이 {NULL_PAGEID, NULL_VOLID}로 할당됨
  • 이로 인해 예상치 못한 정보가 쓰여질 수 있음

Implementation

  • max_bestspace_entries 파라미터의 값이 0보다 클 때 start_vpid의 값에 next_vpid의 값을 할당하도록 구현

Remarks

  • N/A

…space_entries parameter is greater than zero
@InChiJun InChiJun self-assigned this Dec 1, 2024
@InChiJun InChiJun requested a review from hornetmj as a code owner December 1, 2024 13:52
@InChiJun InChiJun closed this Dec 1, 2024
@InChiJun InChiJun reopened this Dec 1, 2024
@InChiJun InChiJun marked this pull request as draft December 1, 2024 13:55
@InChiJun InChiJun requested review from H2SU and YeunjunLee December 4, 2024 03:30
@InChiJun InChiJun marked this pull request as ready for review December 4, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants