Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25602] Fix assert() when executing drop table with vacuum_disable=y #5637

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hornetmj
Copy link
Contributor

@hornetmj hornetmj commented Nov 22, 2024

http://jira.cubrid.org/browse/CBRD-25602

Purpose

  • vacuum_disable=y 설정 후 create table - drop table 수행 시 assert() 발생 수정
  • 이슈에 첨부된 콜스택을 보면, vacuum_add_dropped_file()에서 assert() 발생
    • drop 된 heap 파일(테이블)을 vacuum에서 추적하려고 하는데, vacuum_disable=y 설정이라 추적을 위한 vacuum_Dropped_file 정보가 초기화되어 있지 않아 발생하는 문제
  • vacuum_disable은 hidden 파라미터이기 때문에 이슈의 재현 시나리오에서 assert()가 발생하지 않도록만 처리

Implementation

  • drop 시 vacuum의 vacuum_Dropped_file에 추가할 정보를 로깅하는데, vacuum_disable=y 설정일 경우 로깅을 생략하도록 처리

Remarks

  • N/A

@hornetmj hornetmj marked this pull request as ready for review November 22, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants