Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBRD-25329] truncate milli-seconds when converting DATETIME to TIMESTAMP in server side JDBC #5166

Merged
merged 5 commits into from
May 7, 2024
Merged

[CBRD-25329] truncate milli-seconds when converting DATETIME to TIMESTAMP in server side JDBC #5166

merged 5 commits into from
May 7, 2024

Conversation

hyunikn
Copy link
Contributor

@hyunikn hyunikn commented Apr 30, 2024

@hyunikn hyunikn self-assigned this Apr 30, 2024
@hyunikn hyunikn requested review from hgryoo, beyondykk9 and ctshim April 30, 2024 08:46
@hyunikn
Copy link
Contributor Author

hyunikn commented May 2, 2024

I added a commit (c64142e) to suppress milli-seconds truncation of arguments to DATETIME type parameters and another commit (4a69274) that properly uses toDatetime() instead of incorrect toTimestamp() in some places.

@hyunikn hyunikn merged commit 8d9ed3c into CUBRID:develop May 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctshim ctshim ctshim approved these changes

@beyondykk9 beyondykk9 beyondykk9 approved these changes

@hgryoo hgryoo hgryoo approved these changes

Assignees

@hyunikn hyunikn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyunikn @hgryoo @beyondykk9 @ctshim