[CBRD-25297] building Java type import list at code generation stage #5133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyondykk9
reviewed
Apr 22, 2024
| @@ -44,11 +44,28 @@ | |||
|
|
|||
| public class JavaCodeWriter extends AstVisitor<JavaCodeWriter.CodeToResolve> { | |||
|
|
|||
| private Set<String> javaTypesUsed = new HashSet<>(); | |||
|
|
|||
| private void addToImports(String fullJavaType) {} | |||
There was a problem hiding this comment.
It's just dummy method? It looks better to remove the method if it would be used any more.
There was a problem hiding this comment.
It is unused code and should be removed.
Thank you.
ctshim
approved these changes
Apr 22, 2024
beyondykk9
approved these changes
Apr 23, 2024
hgryoo
approved these changes
Apr 23, 2024
YeunjunLee
pushed a commit
that referenced
this pull request
Jun 4, 2024
…5133) * [refactoring] collect Java types to import during the code generation stage rather than earlier stages * [refactoring] removed old code of building Java type import list * minor: raise a semantic error "not supported yet" on AUTONOMOUS_TRANSACTION pragma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25297
. building Java type import list in earlier stages of compilation has been the cause of omitting required Java type imports by mistake. It should be near the Java code generated.
. a small update irrelevant to this issue is applied: semantic error "not supported yet" on autonomous transaction pragma.