[CBRD-25266] (bugfix) CSQL core dump when an undefined column name in a Static SQL Insert statement #1987
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a Static SQL Insert statement
swi0110
reviewed
Nov 28, 2024
| end; | ||
|
|
||
| drop table ttt; | ||
|
|
There was a problem hiding this comment.
bug 등으로 인해 poo가 생성될 경우를 대비해
drop procedure poo;를 추가할 것을 제안드립니다.
There was a problem hiding this comment.
기본적으로 procedure poo 생성되지 않고 에러가 발생함으로 procedure poo가 생성되지 않습니다.
그러므로 drop procedure poo;를 추가 하지 않습니다.
There was a problem hiding this comment.
기본적으로 생성되지는 않습니다만, 혹여 bug로 생성이 될 경우.
다른 tc에 영향을 주게 됩니다.
이런 일이 발생할 경우, 문제의 원인이 되는 tc를 찾기가 매우 어렵습니다.
그래서 위와 같은 제안을 드렸습니다.
There was a problem hiding this comment.
실제로 다른 tc에서 spec상 생성될 수 없던 객체가, spec 변경으로 인하여 생성이 됐고.
이후 다른 tc가 영향을 받아, 대량의 fail이 발생한 적도 있었습니다.
kwonhoil
approved these changes
Nov 28, 2024
hgryoo
approved these changes
Nov 29, 2024
ssihil
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to http://jira.cubrid.org/browse/CBRD-25266
CSQL core dump when an undefined column name in a Static SQL Insert statement