[APIS-1005] Extends the loadBalance Property of JDBC. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhoh3963
reviewed
Nov 29, 2024
| throw e; | ||
| String loadBalValue = connProperties.getConnLoadBal(); | ||
|
|
||
| synchronized (this) { |
There was a problem hiding this comment.
이 구간에 synchronized 를 사용하지 말고 conn_count 함수를 증가시키는 함수를 만들고 해당 함수에만 synchronized로 하는 것이 어떨까요 ?
private synchronized int increment_conn_count() {
conn_count = conn_count+1;
if (conn_count >= Interger.MAX_VALUE) conn_count=1;
return conn_count;
}
그리고 adjustHostList() 함수에서 conn_count++ 대신 count = increment_conn_count(); 변경한 후 local 변수인 count을 이용하면 thread safety 해 보임.
혹시 UJCIManager.connect()가 thread safety 하지 않나요 ?
There was a problem hiding this comment.
의견 감사합니다. 의견대로 적용하겠습니다.
mhoh3963
reviewed
Dec 2, 2024
|
|
||
| private synchronized int increment_conn_count() { | ||
| conn_count = conn_count + 1; | ||
| return conn_count; |
There was a problem hiding this comment.
conn_count가 INT_MAX가 넘는 경우에 대해 처리가 필요해보입니다.
There was a problem hiding this comment.
conn_count 의 overflow에 대한 처리를 추가 했습니다.
kisoo-han
approved these changes
Dec 2, 2024
mhoh3963
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/APIS-1005
Purpose
connection url의 loadBalance property 사용방법을 확장 하였다.
기존 기능에 Round-Robin 방식을 추가함
확장후 loadBalance 사용 방법
loadBalance=true (Round-Robin 방식)
loadBalance=false (기존과 동일, loadBalance 사용안함)
loadBalance=rr (Round-Robin 방식)
loadBalance=sh (Shuffle 방식)