GitHub Actions: Pin ruff to the same version as pre-commit #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to #395 but centralizing it in requirements.txt
ruff does not support python 3.6 anymore (and we should probably drop it here as well), so only check that the tests still pass with the minimum python version rather than also running the linters. Any problems they find should be discovered by the other jobs.
This script should only run tests to check that cheribuild still works rather than also running the linting. This made sense when we didn't have pre-commit enabled, but now pre-commit takes care of that.
Placing it in requirements.txt means the docker images try to install it even though they don't need it.
arichardson
force-pushed
the
pin-ruff-alternative
branch
from
ef306fe to
0474197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #395
but centralizing it in requirements.txt