Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View consistency enhancements, small bug fixes including entitlements fix #92

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

philippzagar
Copy link
Contributor

View consistency, small bug fixes, including entitlements fix

♻️ Current situation & Problem

As of now, some views in the Intake app seem out of place because of different color choices than the main accent color. Furthermore, when using real health records from HealthKit, a crash occurs because of missing entitlements.

⚙️ Release Notes

  • View consistency enhancements, small bug fixes including entitlements fix

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Apr 7, 2024
@philippzagar philippzagar requested review from kcallon and nriedman April 7, 2024 05:27
@philippzagar philippzagar self-assigned this Apr 7, 2024
Copy link
Contributor

@nriedman nriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great Philipp! I didn't see anything that needed to be changed.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 50.91%. Comparing base (dd1dedd) to head (a980a93).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   50.23%   50.91%   +0.68%     
==========================================
  Files          51       51              
  Lines        3156     3163       +7     
==========================================
+ Hits         1585     1610      +25     
+ Misses       1571     1553      -18     
Files Coverage Δ
Intake/AllergyView/AddAllergy.swift 100.00% <100.00%> (ø)
Intake/AllergyView/AllergyRecords.swift 65.11% <ø> (+0.34%) ⬆️
Intake/AllergyView/ReactionSectionView.swift 76.48% <100.00%> (+1.48%) ⬆️
Intake/ChiefComplaintView/LLMOnboardingView.swift 0.00% <ø> (ø)
Intake/ExportView/ScrollablePDF.swift 69.59% <100.00%> (ø)
Intake/Home.swift 95.95% <100.00%> (ø)
Intake/HomeView/LoadLastButton.swift 30.96% <100.00%> (ø)
Intake/HomeView/SettingsButton.swift 86.67% <100.00%> (ø)
Intake/HomeView/StartButton.swift 92.60% <100.00%> (ø)
Intake/SettingsView/ResourceSelection.swift 0.00% <ø> (ø)
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1dedd...a980a93. Read the comment docs.

@philippzagar philippzagar merged commit 3de281d into main Apr 7, 2024
7 checks passed
@philippzagar philippzagar deleted the feat/view-consistency branch April 7, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants