Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Gender on Patient Info + Menstrual View + Fixing Allergy Nav view #74

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

zoyagarg
Copy link
Contributor

@zoyagarg zoyagarg commented Mar 13, 2024

* Checking off our to-do items *

♻️ Current situation & Problem

*Fixed Gender Storing on patient struct.

  • Fixed scrollable
  • fixed nav on allergy based on gender
  • fixed environment variables for social history so it updates dynamically

⚙️ Release Notes

  • remember to use .task for dynamic updates

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 8.30%. Comparing base (8a3fffd) to head (dbe561d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             main     #74      +/-   ##
=========================================
- Coverage   10.31%   8.30%   -2.01%     
=========================================
  Files          62      62              
  Lines        3521    3509      -12     
=========================================
- Hits          363     291      -72     
- Misses       3158    3218      +60     
Files Coverage Δ
Intake/General Data View/PatientInfo.swift 0.00% <0.00%> (-30.70%) ⬇️
Intake/Allergy Records/AllergyRecords.swift 0.00% <0.00%> (ø)
Intake/SocialHistory/MenstrualHistory.swift 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3fffd...dbe561d. Read the comment docs.

@zoyagarg zoyagarg requested a review from apgupta3303 March 13, 2024 00:46
Copy link
Contributor

@apgupta3303 apgupta3303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@apgupta3303 apgupta3303 merged commit 352cad1 into main Mar 13, 2024
7 checks passed
@apgupta3303 apgupta3303 deleted the lastChanges branch March 13, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants