Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Smoking + DataStore #73

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Updating Smoking + DataStore #73

merged 5 commits into from
Mar 12, 2024

Conversation

zoyagarg
Copy link
Contributor

@zoyagarg zoyagarg commented Mar 12, 2024

Update

♻️ Current situation & Problem

Dr. Aalami wanted different questions for smoking and the display on scrollable was not great yet.

⚙️ Release Notes

Changed the questions for smoking, fixed how social history is presented.
Need to work on storing global vars right.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@zoyagarg zoyagarg changed the title Updating Smoking + DataStore (more relevant questions) Updating Smoking + DataStore Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 1.29870% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 10.31%. Comparing base (69592d8) to head (38ee20c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   10.15%   10.31%   +0.17%     
==========================================
  Files          62       62              
  Lines        3579     3521      -58     
==========================================
  Hits          363      363              
+ Misses       3216     3158      -58     
Files Coverage Δ
Intake/Intake.swift 100.00% <100.00%> (ø)
Intake/SocialHistory/MenstrualHistory.swift 0.00% <0.00%> (ø)
Intake/SocialHistory/SmokingHistory.swift 0.00% <0.00%> (ø)
Intake/ScrollablePDF.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69592d8...38ee20c. Read the comment docs.

Copy link
Contributor

@apgupta3303 apgupta3303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@apgupta3303 apgupta3303 merged commit 8a3fffd into main Mar 12, 2024
7 checks passed
@apgupta3303 apgupta3303 deleted the smokingLocal branch March 12, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants