Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final UI changes to scrollable view #70

Merged
merged 26 commits into from
Mar 11, 2024
Merged

Final UI changes to scrollable view #70

merged 26 commits into from
Mar 11, 2024

Conversation

apgupta3303
Copy link
Contributor

Name of the PR

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

*Fixed minor scrollable ui changes

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 10.11%. Comparing base (105eaf1) to head (a97c171).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   10.15%   10.11%   -0.03%     
==========================================
  Files          62       62              
  Lines        3570     3581      +11     
==========================================
  Hits          362      362              
- Misses       3208     3219      +11     
Files Coverage Δ
Intake/ScrollablePDF.swift 0.00% <0.00%> (ø)
Intake/Allergy Records/ReactionPDF.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105eaf1...a97c171. Read the comment docs.

@apgupta3303 apgupta3303 requested review from kcallon and nriedman March 11, 2024 20:24
@apgupta3303 apgupta3303 self-assigned this Mar 11, 2024
Copy link
Contributor

@nriedman nriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes!

@apgupta3303 apgupta3303 merged commit 67abe87 into main Mar 11, 2024
7 checks passed
@apgupta3303 apgupta3303 deleted the AddingScrollablePDF branch March 11, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants