-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1385 update tutorials using eodag cube #1436
base: develop
Are you sure you want to change the base?
Conversation
Code Coverage (Ubuntu)
Diff against develop
Results for commit: 5325e5c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Code Coverage (Windows)
Diff against develop
Results for commit: 5325e5c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase the branch and re-check the querybles section of the cop_cds notebook afterwards!
dfcdbf0
to
4c2baab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review search part in cop_cds tutorial:
- request for variable temperature
- print in if is not executed but should be according to comment
- in first phrase two use cases
In ecmwf tutorial it still says "None product" after the first code block.
- request for variable temperature - print in if was not executed but should be according to comment - typo in first phrase: two use case -> two use cases
@jlahovnik I have pushed the requested changes to cop_cds tutorial. Regarding ecmwf tutorial, I always get a |
Try to add count=True to the request. |
It worked, thank you! |
688aff1
to
f9eafcf
Compare
@jlahovnik I also fixed the mars request in the ecmwf tutorial and a typo in providers.yml on the product origin |
f9eafcf
to
5325e5c
Compare
Updated tuto_cds and tuto_ecmwf
Ref #1385