BFD-3706: Refactor NPI Enrichment #2471
Draft
+2,307
−280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondevun
requested review from
mjburling,
aschey-forpeople and
malessi
as code owners
| .providerCredential(providerCredential) | ||
| .build(); | ||
| String json = objectMapper.writeValueAsString(npiData); | ||
| dos.write((npi + "\t" + json).getBytes()); |
There was a problem hiding this comment.
Since we're in refactoring mode here, I think we may want to also use a CSV writer here instead of hardcoding the tab character. Since we know this NPI data is poorly validated, it's not implausible to think that maybe someone could put a tab character in their org name or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3706
What Does This PR Do?
This code refactors the NPI enrichment to a cleaner, more object oriented approach.
The TSV that is stored on disk and in memory at runtime has been changed to use JSON. When the
retrieveNPiOrgDisplay()method is called, the JSON is mapped to a POJO (instead of a TSV string, as exists right now). This is a much cleaner approach, which allows all of the information that we could possible need from an NPI enrichment to be stored in a single, easy to understand object. This also allows us to easily add more fields as needed, without the need for much refactoring.What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.