Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option 1 to request a token using curl #216

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

greg-pf
Copy link
Contributor

@greg-pf greg-pf commented Nov 7, 2024

Address feedback from Karley's review of staging r79

🎫 Ticket

https://cmsgov.slack.com/archives/CHG7Q7XNH/p1730998587225749

🛠 Changes

Remove option 1 to request a token using curl

ℹ️ Context

we don't provide a sample command on how to actually encode the credentials, and it's cleaner to just point everyone to the curl command with the --user flag

🧪 Validation

Validated in staging
image

Address feedback from Karley's review of staging r79
@greg-pf greg-pf marked this pull request as ready for review November 7, 2024 18:08
@greg-pf greg-pf requested a review from austincanada November 7, 2024 18:08
Copy link
Contributor

@austincanada austincanada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greg-pf greg-pf merged commit 0954e43 into main Nov 7, 2024
1 check passed
@greg-pf greg-pf deleted the greg-pf-patch-1 branch November 7, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants