Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-8196: Rotate public sbx credentials #205

Merged
merged 1 commit into from
Jun 17, 2024
Merged

BCDA-8196: Rotate public sbx credentials #205

merged 1 commit into from
Jun 17, 2024

Conversation

alex-dzeda
Copy link
Contributor

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8196

🛠 Changes

Rotated sandbox credentials and ensured Advanced Large entity is pointed to the correct value.

ℹ️ Context for reviewers

Existing Advanced-Large entity points towards a non-existent model entity, this rotates the credentials for the public sandbox client ids.

✅ Acceptance Validation

Can start export jobs with all of the updated credentials.

🔒 Security Implications

  • This PR adds a new software dependency or dependencies.
  • This PR modifies or invalidates one or more of our security controls.
  • This PR stores or transmits data that was not stored or transmitted before.
  • This PR requires additional review of its security implications for other reasons.

If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.

Copy link
Contributor

@laurenkrugen-navapbc laurenkrugen-navapbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also gave the rotated creds validation and all started a job successfully.

@alex-dzeda alex-dzeda merged commit b392d2e into main Jun 17, 2024
1 check passed
@alex-dzeda alex-dzeda deleted the alex/bcda-8196 branch June 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants