HitsBinner module to compute simple hits maps #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is particularly useful for creating hits maps without storing the Stokes parameters.
nwhitehorn
reviewed
Sep 2, 2023
There was a problem hiding this comment.
This is a pretty invasive patch, and I wonder if there are easier ways to implement it that don't pessimize the normal operating case. For example, I suspect that running with store_stokes_map = False only uses a little less RAM than when store_stokes_map = True and is only very marginally faster, if at all; couldn't you implement this patch more simply by simply not storing the real map at the end? I guess I'm a little unclear on the use case here.
arahlin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module has the same functionality as the
MapBinner, but emits map frames that contain only a singleH(hits) map.