new default icons for selected default labels + filter counter for overview in drawer #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lytics (CCExtractor#169) * test: Added tests for api service * feat: Added Firebase analytics and crashlytics * feat: Added environment variables for sensitive info * Create .env
* test: Added tests for api service * feat: Added Firebase analytics and crashlytics * feat: Added environment variables for sensitive info * Create .env * Delete .env * release: v0.9.1 beta release
|
@AbdulMalikDev added the PR here |
|
@Rushour0 please resolve the conflicts. |
Done @AbdulMalikDev |
|
@Rushour0 Please also make sure the PR is passing all checks. |
Alright my bad, I will check it again, it was working some time ago |
|
@AbdulMalikDev cleared up the flutter analyze error |
|
i checked it last, was working fine |
|
@AbdulMalikDev could you let me know the status of this feature addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default label icons
Made a new enum type - DefaultLabels which maps to the respective png files
A new default label can be added in DefaultLabels, with its corresponding png file in assets/icons with the same name as the label
Example :
label: videos
filename: videos.png
Added a class DefaultPaths
The intelli-sense can make it faster to write these paths, than having to remember them.
Example:
normal string path: assets/icons/
with DefaultPaths: DefaultPaths.defaultLabelIcons
The variable can be autocompleted with intellisense and reduces the need to remember the path if the variables are well named
solution to issue #108
New function addition in the torrent service to count the torrents by filter
All counts of the filters are now visible in the drawer
issue #109 solution