Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial manga loading #85

Open
wants to merge 2 commits into
base: cuttingedge
Choose a base branch
from

Conversation

YodaDaCoda
Copy link

also prettier'd the js files to make it easier to read what was going on

@db-2001
Copy link
Collaborator

db-2001 commented Apr 23, 2024

I'm not sure why the change from const to function is important as it is working as is. When I put in the API URI:PORT the website works fine but trying to put FRONYEND URI/api breaks it. I'll try pulling the absolute latest on my setup and seeing if the issue persists but I'm not sure these changes would have any effect. I do appreciate you cleaning up the JavaScript, though.

@YodaDaCoda
Copy link
Author

I'm not sure why the change from const to function is important

the javascript is executed as it is parsed down the file. the call to setup() happens before the const stringToColour was in scope. functions are 'hoisted' so they're always in scope.

When I put in the API URI:PORT the website works fine but trying to put FRONYEND URI/api breaks it

you mean in the Settings panel of the site?
image

are you sure it's nginx that's not passing the request along? i'm running cuttingedge for both

@db-2001
Copy link
Collaborator

db-2001 commented Apr 26, 2024

I restarted the container and it started working fine, I'll make your change from const() to function() in the V2 branch, they're too different to merge easily at this point.

db-2001 added a commit to db-2001/tranga-website that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants