-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend v2 #84
base: dev
Are you sure you want to change the base?
Frontend v2 #84
Conversation
Resized settings pop-up and fixed scrollable behavior, broke everything inside pop-up (on purpose)
Added Test and Rest API calls, API side will need to be updated. Separated out CSS files for future expansion.
Removed textbox in top bar and added filter icon that opens up a box where you can search or select a connector/status and combination to filter by. Appearance and behavior needs to be refined.
Added the manga sources to the settings page and added a field to set the rate limit, POST api for setting the rate limit awaiting GET api calls to set initial value.
Changed CSS style to be stored in local storage since we might want it to be browser specific (mobile vs desktop vs tablet)
…ng twice sometimes
…an placeholder Allows for the user to make small changes to API URI and user agent if needed, previous method would have required re-typing in the entire string with is a PITA.
Removed the hard-coded http in the API url and instead calling window.location.protocol
Settings rework with Filter changes
Updating Dev branch so we can actually start using it for dev things
Updated the docker workflow files
Updated github workflows
Reverse Proxy api automatically test
conf tweaks
more conf tweaks
I think it just doesn't add the job, but doesn't respond an error code if it was unsuccessful... |
Hey @C9Glax, I'm really sorry for being MIA for a few months, I've been really busy trying to get setup in a new city with a new job. I feel really bad about leaving this PR in what I consider an unfinished state but I don't know if I'll be able to get the time to finish off the API migration. I've changed the base to dev, would you be able to take it from here? I think there are some really nice UI tweaks and improvements which I'd like to share with everyone. (Any feedback is welcome of course) As for the API migration which took me the longest, it's still very not optimized for how the new API calls work, I tried to improve it and start from scratch the javascript about 3 times but it ended up being too much for me to do, so sorry about that :( . I think for the most part, everything works like it used to with the old API, but there's something funky going on with the running/waiting jobs that I'm not able to figure out. As for the future, I do hope and wish to continue contributing to the frontend, but maybe in smaller chunks so I can actually get stuff done, haha,
|
Hey! I tried pulling some of your fixes in the past month, but did not get very far yet, especially on the frontend this project is still lacking, so I look forward to the day I can release your changes 👍🏼 I hope you will like both city and job, until we write again. |
Draft PR for V2 of the front-end, will implement the JSON api once server side is set up so I can test with it.
Addresses #83
Addresses #59
Addresses #79