Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend v2 #84

Draft
wants to merge 52 commits into
base: dev
Choose a base branch
from
Draft

Frontend v2 #84

wants to merge 52 commits into from

Conversation

db-2001
Copy link
Collaborator

@db-2001 db-2001 commented Apr 21, 2024

Draft PR for V2 of the front-end, will implement the JSON api once server side is set up so I can test with it.

Addresses #83
Addresses #59
Addresses #79

db-2001 and others added 30 commits February 3, 2024 00:41
Resized settings pop-up and fixed scrollable behavior, broke everything inside pop-up (on purpose)
Added Test and Rest API calls, API side will need to be updated.

Separated out CSS files for future expansion.
Removed textbox in top bar and added filter icon that opens up a box where you can search or select a connector/status and combination to filter by. Appearance and behavior needs to be refined.
Added the manga sources to the settings page and added a field to set the rate limit, POST api for setting the rate limit awaiting GET api calls to set initial value.
Changed CSS style to be stored in local storage since we might want it to be browser specific (mobile vs desktop vs tablet)
…an placeholder

Allows for the user to make small changes to API URI and user agent if needed, previous method would have required re-typing in the entire string with is a PITA.
Removed the hard-coded http in the API url and instead calling  window.location.protocol
Settings rework with Filter changes
Updating Dev branch so we can actually start using it for dev things
Updated the docker workflow files
Reverse Proxy api automatically test
@db-2001
Copy link
Collaborator Author

db-2001 commented Apr 25, 2024

Resolves #64
Resolves #46
Resolves #40
Resolves #21
Resolves #52

@db-2001
Copy link
Collaborator Author

db-2001 commented Apr 25, 2024

Finalized search window:
image
Combined download button and in-library indicator so it's clear that you can't readd a manga (I know the API technically allows this but seems like weird behavior)

@db-2001
Copy link
Collaborator Author

db-2001 commented Apr 25, 2024

image

Hovering over the manga name in the search window lets you click it and you get sent to the manga connector. Currently implemented for search window, need to remember to do it for manga details window.

@db-2001 db-2001 linked an issue Apr 25, 2024 that may be closed by this pull request
@db-2001
Copy link
Collaborator Author

db-2001 commented Apr 25, 2024

image

New Progress Bar that looks the same on all platforms. I can't figure out why the animations don't want to work the same as Firefox on Chrome and Edge tho but both do have animations, they just look very different.

@C9Glax
Copy link
Owner

C9Glax commented Apr 25, 2024

Combined download button and in-library indicator so it's clear that you can't re-add a manga (I know the API technically allows this but seems like weird behavior)

I think it just doesn't add the job, but doesn't respond an error code if it was unsuccessful...

@db-2001
Copy link
Collaborator Author

db-2001 commented May 18, 2024

Updated the manga viewer pop-up. I thought we had the ability to individually download select chapters in the API but I'm not seeing it. We don't need it For V2 of Tranga, we can keep it as something that we do eventually. With this I'll be forking over the new API code and then over the next couple weeks, tweaking the behavior to work with it.
Before:
image
After:
image

Also made some basic CSS changes to help with mobile devices:
Before:
image

After:
image

@db-2001 db-2001 changed the base branch from cuttingedge to dev August 12, 2024 01:17
@db-2001
Copy link
Collaborator Author

db-2001 commented Aug 12, 2024

Hey @C9Glax, I'm really sorry for being MIA for a few months, I've been really busy trying to get setup in a new city with a new job.

I feel really bad about leaving this PR in what I consider an unfinished state but I don't know if I'll be able to get the time to finish off the API migration. I've changed the base to dev, would you be able to take it from here? I think there are some really nice UI tweaks and improvements which I'd like to share with everyone. (Any feedback is welcome of course)

As for the API migration which took me the longest, it's still very not optimized for how the new API calls work, I tried to improve it and start from scratch the javascript about 3 times but it ended up being too much for me to do, so sorry about that :( . I think for the most part, everything works like it used to with the old API, but there's something funky going on with the running/waiting jobs that I'm not able to figure out.

As for the future, I do hope and wish to continue contributing to the frontend, but maybe in smaller chunks so I can actually get stuff done, haha,

  • DB

@db-2001 db-2001 marked this pull request as ready for review August 12, 2024 01:21
@C9Glax
Copy link
Owner

C9Glax commented Aug 13, 2024

Hey!
Do not feel guilty or pressured to work on this. I am very grateful for everything you have already contributed, and will wait with open arms for when/if you have the time, energy and will to add/fix another issue :)

I tried pulling some of your fixes in the past month, but did not get very far yet, especially on the frontend this project is still lacking, so I look forward to the day I can release your changes 👍🏼

I hope you will like both city and job, until we write again.
Glax

@C9Glax C9Glax marked this pull request as draft August 26, 2024 17:36
@C9Glax C9Glax mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment