Fix typos #209
Fix typos #209
Conversation
NathanBaulch
force-pushed
the
typos
branch
2 times, most recently
from
bdd667c to
b312b75
Compare
There was a problem hiding this comment.
I don't know if you love doing tedious combing over docs/code or you have a wonderful spell checker, but you're doing "god's work" here.
The sheer volume of spelling and grammatical errors is egregious (and most of them are probably mine).
Seems like its time for a better spell checker or we need to tweak golangci's spelling linter(s).
Only one thing, like the test improvement PR, please add an entry to the CHANGELOG.md, otherwise, this is much appreciated work!!!!
| @@ -27,7 +27,7 @@ type Options struct { | |||
| KnownHostsFile string `json:"knownHostsFile,omitempty"` // env var VFS_SFTP_KNOWN_HOSTS_FILE | |||
| KnownHostsString string `json:"knownHostsString,omitempty"` | |||
| KeyExchanges []string `json:"keyExchanges,omitempty"` | |||
| Ciphers []string `json:"cihers,omitempty"` | |||
| Ciphers []string `json:"ciphers,omitempty"` | |||
There was a problem hiding this comment.
oh wow... that's a good catch... this is probably breaking for someone, somewhere.
There was a problem hiding this comment.
Can we support reading both fields but always write the correct spelling when marshaling moving forward?
|
Heh, I use a combination of the typos tool along with the JetBrains IDE language inspections. |
Fixes a bunch of typos and minor grammar issues that I've stumbled on.