Unit test improvements #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBaulch
force-pushed
the
tests
branch
3 times, most recently
from
fb3fcb6 to
54cef4e
Compare
c2fo-cibot
bot
added
size/XXL
funkyshu
reviewed
Nov 3, 2024
| fileList, err := loc.ListByPrefix(test.prefix) | ||
| lt.NoError(err, test.description) | ||
| lt.Equal(test.expectedFiles, fileList, test.description) | ||
| lt.Run(test.description, func() { |
There was a problem hiding this comment.
love it... makes for easier runing for table-driven tests.
funkyshu
reviewed
Nov 3, 2024
| if err != nil { | ||
| ts.Fail("Shouldn't return error creating test s3.File instance.") | ||
| } | ||
| ts.Require().NoError(err, "Shouldn't return error creating test s3.File instance.") |
funkyshu
approved these changes
Nov 3, 2024
funkyshu
requested changes
Nov 3, 2024
There was a problem hiding this comment.
Actually only one change needed, update the CHANGELOG.md, under ## [Unreleased] with summary of your changes, adhering to https://keepachangelog.com/en/1.1.0/ semantics.
For instance:
## [Unreleased]
### Fixed
- Unit Test improvements: report underlying unit tests errors, always run test cases in sub-test, always use test suite functions, use more specific assert functions where possible.When a release is created we'll update the section for the release.
funkyshu
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of improvements to make failing unit tests a little easier to diagnose.