Wip/site rework #194
Merged
Wip/site rework #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added client side UI for sites - Data still needs to be set manually.
- Personal sites were removed - Sites now send rewards - New UI for sites - Added rewards, which is the server telling a def and an amount to give to a client.
- Owners will now properly keep their sites when leaving, deleting and creating factions - Rewards now properly arrive at their destination.
- New update command to update from old sites to new sites. - Fixed issue where good will wouldn't update properly when leaving and getting kicked from factions. - Cleaned up some code - Added descriptions to sites.
- Server now has "balanced" default values - Server now remembers and uses the user's site config - New client side button for config menu
- Fixed bug where rewards would be sometime doubled. - Fixed bug where sites didn't update their factionfiles properly. - Removed redundant variable in Sites. - Fixed typos in config. - Added a new site (it was for testing, but I already did the work so it stays) - Added a few verbose logs for troubleshooting sake
- Fixed where faction members could destroy sites.
Issue came from windows being a dumb with case sensitivity. God I hate windows
- Rewards will now prompt an error when failing to find a def. - Sites will now prevent opening the UI if the cost or rewards are non existent - Sites will now exclude any non-existing rewards or cost defs. - Configs now sync properly on server restarts
- Implemented new packet system - Fixed reward managers having issues. - Fixed issue with configs not being applied properly.
Site implementation
- Added DefOf instead of a bunch of static instances across the project.
Final fixes Site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short and concise description about my pull request:
TODOs:
Longer / More informative description about what my pull request does: