Fix set bldg and system type #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/files/v2.4.0/building_151.xml
Outdated
| @@ -72,7 +72,7 @@ | |||
| <auc:YearOfLastMajorRemodel>2003</auc:YearOfLastMajorRemodel> | |||
| <auc:Sections> | |||
| <auc:Section ID="Default_Section"> | |||
| <auc:OccupancyClassification>Retail</auc:OccupancyClassification> | |||
| <auc:OccupancyClassification>Multifamily</auc:OccupancyClassification> | |||
There was a problem hiding this comment.
Suggested change
| <auc:OccupancyClassification>Multifamily</auc:OccupancyClassification> | |
| <auc:OccupancyClassification>Retail</auc:OccupancyClassification> |
There was a problem hiding this comment.
Reverting this back to original classification.
There was a problem hiding this comment.
This is important for the test. Prior to the change in lib/buildingsync/model_articulation/building_section.rb, a bsync file with OccupancyClassification Multifamily would break the gem. So I wanted to add that test case
haneslinger
force-pushed
the
FIX-set_bldg_and_system_type
branch
2 times, most recently
from
cf29ca9 to
010060f
Compare
ThibaultMarzullo
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#144
The test change break things cause "Mutli family" has a maxfloor, and that comparison is broken.
This fixes things because the wrong variable was being used in the comparison.